gh-104773: PEP 594: Remove the sndhdr module - #104774
Merged
vstinner merged 1 commit intoMay 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Member
Author
|
I ignored mentions of the sndhdr module in comments of the email module, Lib/email/mime/audio.py: # Originally from the sndhdr module.
#
# There are others in sndhdr that don't have MIME types. :(
# Additional ones to be added to sndhdr? midi, mp3, realaudio, wma??
def _what(data):
# Try to identify a sound file type.
#
# sndhdr.what() had a pretty cruddy interface, unfortunately. This is why
# we re-do it here. It would be easier to reverse engineer the Unix 'file'
# command and use the standard 'magic' file, as shipped with a modern Unix.
hdr = data[:512]
fakefile = BytesIO(hdr)
for testfn in _rules:
if res := testfn(hdr, fakefile):
return res
else:
return None |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Fix the Docs CI: Warning: (...)/Doc/whatsnew/3.12.rst:819: WARNING: py:mod reference target not found: sndhdr. |
Sorry, something went wrong.
gpshead
approved these changes
May 23, 2023
hugovk
reviewed
May 23, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please could you also update the refs in 3.11.rst?
For example with an exclamation mark:
* :pep:`594` led to the deprecations of the following modules
slated for removal in Python 3.13:
+---------------------+---------------------+---------------------+---------------------+---------------------+
| :mod:`aifc` | :mod:`chunk` | :mod:`msilib` | :mod:`pipes` | :mod:`telnetlib` |
+---------------------+---------------------+---------------------+---------------------+---------------------+
| :mod:`audioop` | :mod:`crypt` | :mod:`nis` | :mod:`!sndhdr` | :mod:`uu` |
+---------------------+---------------------+---------------------+---------------------+---------------------+
| :mod:`cgi` | :mod:`imghdr` | :mod:`nntplib` | :mod:`spwd` | :mod:`xdrlib` |
+---------------------+---------------------+---------------------+---------------------+---------------------+
| :mod:`cgitb` | :mod:`mailcap` | :mod:`ossaudiodev` | :mod:`sunau` | |
+---------------------+---------------------+---------------------+---------------------+---------------------+
You could do them all in a single commit/PR, to avoid lots of conflicts later.
And:
diff --git a/Doc/whatsnew/3.5.rst b/Doc/whatsnew/3.5.rst
index 14b6425cea..a1b6e18950 100644
--- a/Doc/whatsnew/3.5.rst
+++ b/Doc/whatsnew/3.5.rst
@@ -1714,7 +1714,7 @@ support :rfc:`6531` (SMTPUTF8).
sndhdr
------
-The :func:`~sndhdr.what` and :func:`~sndhdr.whathdr` functions now return
+The ``what`` and ``whathdr`` functions now return
a :func:`~collections.namedtuple`. (Contributed by Claudiu Popa in
:issue:`18615`.)
Sorry, something went wrong.
Remove the Lib/test/sndhdrdata/ directory.
Copy link
Copy Markdown
Member
Author
|
I updated the doc: I added PEP 594 and replaced sndhdr with !sndhdr. I also rebased the PR on the main to retrieve recent test fixes (especially test_importlib). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Lib/test/sndhdrdata/ directory.
📚 Documentation preview 📚: https://cpython-previews--104774.org.readthedocs.build/