FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 by hugovk · Pull Request #104816 · python/cpython · GitHub

/ cpython Public

gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 - #104816

Merged
hugovk merged 8 commits into
python:mainfrom
hugovk:rm-webbrowser-MacOSX
May 26, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11#104816
hugovk merged 8 commits into
python:mainfrom
hugovk:rm-webbrowser-MacOSX

Conversation

hugovk commented May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #104804.

Remove webbrowser.MacOSX class, deprecated in Python 3.11 in gh-86421.

Also fix Sphinx warnings in webbrowser.rst (helps gh-101100):

  • I don't think we need to define envvars for PATH or KDEDIR

  • We could define .. envvar:: BROWSER right before the first mention, but it looks a little out of place having a BROWSER before the third paragraph. Thoughts?

  • I also don't think we need to define the dozen or so Mozilla, Opera etc. classes. They're listed in the table that shows which type name corresponds to each class, and some of them have extra details like how they're instantiated (Mozilla('mozilla'), GenericBrowser('lynx')), so plain literal text makes sense here. Repeating each class below would be a lot of duplication for little benefit, especially for this rather short page.

  • https://cpython-previews--104816.org.readthedocs.build/en/104816/library/webbrowser.html

📚 Documentation preview 📚: https://cpython-previews--104816.org.readthedocs.build/

hugovk changed the title Remove webbrowser.MacOSX class, deprecated in Python 3.11 gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 May 23, 2023
bedevere-bot mentioned this pull request May 23, 2023
Closed
hugovk mentioned this pull request May 23, 2023
Closed

serhiy-storchaka commented May 23, 2023

Copy link
Copy Markdown
Member

Would not be better to split this PR on two? One for removing, and other for tidying?

CAM-Gerlach added the stdlib Standard Library Python modules in the Lib/ directory label May 23, 2023

hugovk commented May 23, 2023

Copy link
Copy Markdown
Member Author

I can do, but they are intertwined: this bit is removed, which otherwise has warnings that would need fixing, or waiting for part 1 to be merged:

.. deprecated-removed:: 3.11 3.13
   :class:`MacOSX` is deprecated, use :class:`MacOSXOSAScript` instead.

Seems easier to do both at once. But either way is fine for me :)

CAM-Gerlach reviewed May 23, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I had a handful of doc-related suggestions. Otherwise, the core change looks good. The removal of the :class: syntax for things that are really code snippits (and not formally documented anyway) makes sense, as does silencing warnings for env vars not explicitly defined by or primarily/exclusively used by Python itself.

Ideally it would be nice to split it into two PRs as @serhiy-storchaka , but as a practical matter given they interlinked, maybe not worth the extra effort.

Comment thread Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst Outdated
Comment thread Misc/NEWS.d/3.11.0a1.rst Outdated
Comment thread Doc/whatsnew/3.13.rst Outdated
Comment thread Doc/library/webbrowser.rst
hugovk added the 3.13 bugs and security fixes label May 25, 2023
hugovk mentioned this pull request May 25, 2023
Merged
vstinner reviewed May 25, 2023
View reviewed changes
Comment thread Doc/library/webbrowser.rst
Comment thread Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst Outdated
vstinner approved these changes May 25, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if you fix the typo in the NEWS entry.

Fix typo
4333217 
Co-authored-by: Victor Stinner <vstinner@python.org>
hugovk merged commit 5ab4bc0 into python:main May 26, 2023
hugovk deleted the rm-webbrowser-MacOSX branch May 26, 2023 13:54
hugovk mentioned this pull request Apr 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
vstinner vstinner approved these changes

Assignees

No one assigned

Labels

3.13 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated webbrowser.MacOSX class

5 participants

Back | FazBrowse Home | New Git URL