FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104797: Allow Protocols to inherit from collections.abc.Buffer by JelleZijlstra · Pull Request #104827 · python/cpython · GitHub

/ cpython Public

gh-104797: Allow Protocols to inherit from collections.abc.Buffer - #104827

Merged
AlexWaygood merged 3 commits into
python:mainfrom
JelleZijlstra:bufpro
May 24, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-104797: Allow Protocols to inherit from collections.abc.Buffer#104827
AlexWaygood merged 3 commits into
python:mainfrom
JelleZijlstra:bufpro

Conversation

JelleZijlstra commented May 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 24, 2023
Closed
bedevere-bot added the docs Documentation in the Doc dir label May 24, 2023
AlexWaygood approved these changes May 24, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

AlexWaygood enabled auto-merge (squash) May 24, 2023 06:23
AlexWaygood merged commit c0ab7d4 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-104797: Allow Protocols to inherit from collections.abc.Buff…
42a05db 
…er (pythonGH-104827)

(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104841 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
AlexWaygood pushed a commit that referenced this pull request May 24, 2023
[3.12] gh-104797: Allow Protocols to inherit from collections.abc.Buf…
d10d1e3 
…fer (GH-104827) (#104841)

gh-104797: Allow Protocols to inherit from collections.abc.Buffer (GH-104827)
(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

This comment was marked as off-topic.

Sign in to view
AlexWaygood mentioned this pull request Jun 4, 2023
Merged
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use multiple inheritance with collections.abc.Buffer and typing.Protocol

4 participants

Back | FazBrowse Home | New Git URL