FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104773: PEP 594: Remove the chunk module by vstinner · Pull Request #104868 · python/cpython · GitHub

/ cpython Public

gh-104773: PEP 594: Remove the chunk module - #104868

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_chunk
May 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-104773: PEP 594: Remove the chunk module#104868
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_chunk

Conversation

vstinner commented May 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
hugovk requested changes May 24, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

Oh, I missed that one: it's now removed.

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-bot requested a review from hugovk May 24, 2023 15:16
hugovk approved these changes May 24, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

vstinner enabled auto-merge (squash) May 24, 2023 15:26

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

Oh. test_aifc uses the chunk module. It should be removed before the chunk module can be removed:

test test_aifc crashed -- Traceback (most recent call last):
(...)
  File "D:\a\cpython\cpython\Lib\aifc.py", line 260, in <module>
    from chunk import Chunk
ModuleNotFoundError: No module named 'chunk'

vstinner marked this pull request as draft May 24, 2023 15:43
auto-merge was automatically disabled May 24, 2023 15:43

Pull request was converted to draft

vstinner changed the title gh-104773: PEP 594: Remove the chunk module WIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk module May 24, 2023
vstinner mentioned this pull request May 25, 2023
Merged
vstinner changed the title WIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk module gh-104773: PEP 594: Remove the chunk module May 25, 2023
vstinner marked this pull request as ready for review May 25, 2023 16:02

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

PR rebased on main, now that the aifc module has been removed.

vstinner enabled auto-merge (squash) May 25, 2023 16:09
vstinner merged commit 77d7ec5 into python:main May 25, 2023
vstinner deleted the remove_chunk branch May 25, 2023 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL