FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104873: Add typing.get_protocol_members and typing.is_protocol by JelleZijlstra · Pull Request #104878 · python/cpython · GitHub

/ cpython Public

gh-104873: Add typing.get_protocol_members and typing.is_protocol - #104878

Merged
JelleZijlstra merged 14 commits into
python:mainfrom
JelleZijlstra:protoattrs
Jun 14, 2023
ConversationCommits (14)ChecksFiles changed
Merged

gh-104873: Add typing.get_protocol_members and typing.is_protocol#104878
JelleZijlstra merged 14 commits into
python:mainfrom
JelleZijlstra:protoattrs

Conversation

JelleZijlstra commented May 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 24, 2023
Closed
AlexWaygood requested changes May 24, 2023
View reviewed changes
Comment thread Lib/typing.py Outdated
Comment thread Lib/typing.py Outdated

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

JelleZijlstra changed the title gh-104873: Add typing.get_protocol_members gh-104873: Add typing.get_protocol_members and typing.is_protocol May 24, 2023

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

@AlexWaygood: please review the changes made to this pull request.

bedevere-bot requested a review from AlexWaygood May 24, 2023 18:04
AlexWaygood reviewed May 24, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/typing.py Outdated
Comment thread Lib/typing.py
JelleZijlstra and others added 2 commits May 24, 2023 13:10
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated
Comment thread Lib/test/test_typing.py Outdated
Update Doc/whatsnew/3.13.rst
c91acbb 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Doc/library/typing.rst
Comment thread Doc/library/typing.rst Outdated
Comment thread Lib/typing.py Outdated
Comment thread Lib/typing.py Outdated
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Outdated
AlexWaygood approved these changes Jun 5, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I'd love to get a third opinion from @gvanrossum or @Fidget-Spinner on the API, if possible

JelleZijlstra commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

FYI I also just emailed typing-sig about this to ask for feedback.

JelleZijlstra commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

Nobody spoke up against this on typing-sig, time to merge?

AlexWaygood reviewed Jun 13, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/test/test_typing.py Outdated
AlexWaygood reviewed Jun 13, 2023
View reviewed changes
Comment thread Lib/typing.py Outdated
JelleZijlstra and others added 3 commits June 13, 2023 19:37
Apply suggestions from code review
fc4eb5d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Merge remote-tracking branch 'upstream/main' into protoattrs
7e8636a
Update Lib/typing.py
8b31c81 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changes Jun 14, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Time to merge, in my opinion!

JelleZijlstra merged commit fc8037d into python:main Jun 14, 2023
JelleZijlstra deleted the protoattrs branch June 14, 2023 12:43
JelleZijlstra restored the protoattrs branch September 10, 2024 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL