FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104879: Fix TypeAliasType.__module__ in exec() by JelleZijlstra · Pull Request #104881 · python/cpython · GitHub

/ cpython Public

gh-104879: Fix TypeAliasType.__module__ in exec() - #104881

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:tatmod
May 24, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-104879: Fix TypeAliasType.__module__ in exec()#104881
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:tatmod

Conversation

JelleZijlstra commented May 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

JelleZijlstra added the needs backport to 3.12 only security fixes label May 24, 2023
bedevere-bot mentioned this pull request May 24, 2023
Closed
JelleZijlstra commented May 24, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py
self.assertIs(T.__infer_variance__, False)
self.assertEqual(T.__module__, __name__)

def test_basic_with_exec(self):

JelleZijlstra May 24, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These tests already passed, but adding them here for completeness

JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 24, 2023

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a6e5d5e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 24, 2023
JelleZijlstra merged commit fe77a99 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

JelleZijlstra deleted the tatmod branch May 24, 2023 18:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-104879: Fix TypeAliasType.__module__ in exec() (pythonGH-104881
79b6101 
)

(cherry picked from commit fe77a99)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104890 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
JelleZijlstra added a commit that referenced this pull request May 24, 2023
[3.12] gh-104879: Fix TypeAliasType.__module__ in exec() (GH-104881) (#…
b670214 
…104890)

(cherry picked from commit fe77a99)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
JelleZijlstra restored the tatmod branch September 10, 2024 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sunmy2019 sunmy2019 approved these changes
Eclips4 Eclips4 approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner
AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL