FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104886: Remove deprecated configparser.LegacyInterpolation by hugovk · Pull Request #104887 · python/cpython · GitHub

/ cpython Public

gh-104886: Remove deprecated configparser.LegacyInterpolation - #104887

Merged
hugovk merged 5 commits into
python:mainfrom
hugovk:rm-configparser.LegacyInterpolation
May 26, 2023
Merged

gh-104886: Remove deprecated configparser.LegacyInterpolation#104887
hugovk merged 5 commits into
python:mainfrom
hugovk:rm-configparser.LegacyInterpolation

Conversation

hugovk commented May 24, 2023
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Closes #104886.

Remove the undocumented configparser.LegacyInterpolation class.

It was deprecated in the docstring since Python 3.2, deprecated with a warning since Python 3.11, and scheduled for removal in 3.13.


📚 Documentation preview 📚: https://cpython-previews--104887.org.readthedocs.build/

hugovk added stdlib Standard Library Python modules in the Lib/ directory 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I just had a minor suggestion.

@ambv: Was it you who changed this interpolation method?

Wow, it took a while to completely finish the transition :-)

Comment thread Doc/whatsnew/3.13.rst Outdated

ambv commented May 25, 2023

Copy link
Copy Markdown
Contributor

Yeah, I originally never intended to remove the old one but here we are!

Copy link
Copy Markdown
Member

Yeah, I originally never intended to remove the old one but here we are!

Well, you first wrote:

class BrokenInterpolation(Interpolation):
    """Deprecated interpolation as implemented in the classic ConfigParser.

It was marked as "deprecated" in the docstring ;-)

Maybe it's time to break the API again, and add a pending deprecated VeryBadlyBrokenInterpolation class :-D

hugovk and others added 2 commits May 25, 2023 19:28
Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

hugovk enabled auto-merge (squash) May 26, 2023 05:43
hugovk merged commit 3f9c60f into python:main May 26, 2023
hugovk deleted the rm-configparser.LegacyInterpolation branch May 26, 2023 06:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.13 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated configparser.LegacyInterpolation class

4 participants


Back | FazBrowse Home | New Git URL