gh-104773: PEP 594: Remove the nis module - #104897
Merged
vstinner merged 3 commits intoMay 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Member
|
Some extra nismodule / libnsl bits to remove? Tools/c-analyzer/cpython/ignored.tsv 285:Modules/nismodule.c - TIMEOUT - 286:Modules/nismodule.c - aliases - Tools/c-analyzer/cpython/_parser.py 123:Modules/nismodule.c /usr/include/tirpc Tools/c-analyzer/cpython/globals-to-fix.tsv 458:Modules/nismodule.c nisproc_maplist_2 res - PC/pyconfig.h 679:#define HAVE_LIBNSL 1 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Well spotted: removed as well. For now, I prefer to keep this code in configure.ac, since I don't know its purpose and I cannot test a change on Solaris: $ git grep -B1 -A1 '\<nsl\>' configure.ac-# Most SVR4 platforms (e.g. Solaris) need -lsocket and -lnsl. configure.ac:AC_CHECK_LIB(nsl, t_open, [LIBS="-lnsl $LIBS"]) # SVR4 configure.ac-AC_CHECK_LIB(socket, socket, [LIBS="-lsocket $LIBS"], [], $LIBS) # SVR4 sockets |
Sorry, something went wrong.
hugovk
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--104897.org.readthedocs.build/