Small speedup for dataclass __eq__ and __repr__ - #104904
Merged
ericvsmith merged 4 commits intoMay 30, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
carljm
approved these changes
May 24, 2023
carljm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Those look great, @rhettinger! Thanks. I'll do a detailed code review then commit it. |
Sorry, something went wrong.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 30, 2023
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110) pythongh-105071: add missing versionadded directive (python#105097) pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904) pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093) pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
Copy link
Copy Markdown
Contributor
|
I belive I found a regression: #116647 |
Sorry, something went wrong.
This was referenced Jun 17, 2024
Copy link
Copy Markdown
Member
|
Or you found that this resulted in a perhaps inadvertent bugfix ;-). Depends on Eric's intention for NANs in dataclasses. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old code:
def __eq__(self,other): if other.__class__ is self.__class__: return (self.a,self.b,)==(other.a,other.b,) def __repr__(self): return self.__class__.__qualname__ + f"(a={self.a!r}, b={self.b!r})"New code:
def __eq__(self,other): if other.__class__ is self.__class__: return self.a==other.a and self.b==other.b def __repr__(self): return f"{self.__class__.__qualname__}(a={self.a!r}, b={self.b!r})"Timings for a dataclass with two integer fields:
Both Equal First Equal Neither Equal Repr ========== =========== ============= ============ Baseline 0.09769874 0.10188975 0.10144600 0.18586733 With PR 0.08537712 0.08647508 0.070007080 0.18308112