gh-104773: PEP 594: Remove the msilib package - #104911
Conversation
Sorry, something went wrong.
|
msilib/__init__.py starts with from _msi import *: the _msi extension should be removed as well, no? Do you plan to remove it as a separated PR? |
Sorry, something went wrong.
|
Note: The msilib module was used by the bdist_msi command of distutils, but this command was removed in Python 3.11, and the whole distutils package was removed in Python 3.12. See the bdist_msi deprecation in Python 3.9 for the rationale: issue #83767. Now it's fine to remove this deprecated msilib module. Well, PEP 594 has a longer rationale. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
The _msi extension can be removed in a separated PR.
Sorry, something went wrong.
|
Using import msilib|from msilib regex, I found the following projects of PyPI top 5,000 projects (at 2023-04-13) using the removed msilib module. Affected projects (2):
pygame-2.3.0/setup.py: import msilib mpi4py-3.1.4/conf/mpidistutils.py: import msilib |
Sorry, something went wrong.
|
Does Tools\msi\build.bat use msilib module or _msi extension? Or does it use Windows tooling instead? There is .github/workflows/build_msi.yml which runs Tools\msi\build.bat, but I don't know what triggers this GHA job. Is it when one file in Tools/msi/ is modified? It may be interesting to check that these tools and/or this GHA job still work ;-) |
Sorry, something went wrong.
|
Oh wait, I see a TestsMSI / Windows Installer (x64) (pull_request) In progress task running! It will tell us if it still works :-) |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM. The msilib LGTM. For the _msi removal, I'm not 100% confident that I can review the VS solution changes (but from what I saw, it LGTM as well).
Sorry, something went wrong.
Version-specific patches adapted from existing ones: - relocatable-python-config: same change as 3.x-0001 but adjusted for line offset in 3.13+ python-config.sh.in (shared between 3.13 and 3.14 since the file is identical) - remove-module-deps: removes ProjectDependencies from the python project in PCbuild/pcbuild.sln (separate patches for 3.13 and 3.14 due to different GUID sets) - _ctypes-ffi (3.13 only): converts static formattable[] array to dynamic initialization for shared libffi compatibility. Not needed for 3.14 where this was fixed upstream by restructuring cfield.c into a named struct (python/cpython#117671) The _msi-vcxproj patch is no longer needed since msilib was removed in 3.13 per PEP 594 (python/cpython#104911).
📚 Documentation preview 📚: https://cpython-previews--104911.org.readthedocs.build/