GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms - #104948
Merged
barneygale merged 3 commits intoMay 26, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…across OSs Use `str.lower()` rather than `ntpath.normcase()` to normalize case of Windows paths. This restores behaviour from Python 3.11.
barneygale
marked this pull request as ready for review
May 25, 2023 22:44
gpshead
approved these changes
May 26, 2023
barneygale
enabled auto-merge (squash)
May 26, 2023 17:42
Copy link
Copy Markdown
Contributor
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2023
…across platforms (pythonGH-104948) Use `str.lower()` rather than `ntpath.normcase()` to normalize case of Windows paths. This restores behaviour from Python 3.11. (cherry picked from commit ad0be36) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
Copy link
Copy Markdown
|
GH-104990 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
barneygale
added a commit
that referenced
this pull request
May 26, 2023
… across platforms (GH-104948) (GH-104990) Use `str.lower()` rather than `ntpath.normcase()` to normalize case of Windows paths. This restores behaviour from Python 3.11. (cherry picked from commit ad0be36) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use str.lower() rather than ntpath.normcase() to normalize case of Windows paths. This restores behaviour from Python 3.11.