[3.11] gh-103921: Improve typing documentation (GH-104642) - #105007
Merged
JelleZijlstra merged 3 commits intoMay 27, 2023
Merged
[3.11] gh-103921: Improve typing documentation (GH-104642)#105007JelleZijlstra merged 3 commits into
JelleZijlstra merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
requested review from
AlexWaygood,
Fidget-Spinner and
gvanrossum
as code owners
May 27, 2023 01:25
This was referenced May 27, 2023
Closed
AlexWaygood
reviewed
May 27, 2023
Comment thread
Doc/library/typing.rst
Outdated
Comment thread
Doc/library/typing.rst
Outdated
Comment thread
Doc/library/typing.rst
Outdated
Comment thread
Doc/library/typing.rst
Comment thread
Doc/library/typing.rst
Outdated
Thanks Alex! Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
May 27, 2023
AlexWaygood
requested changes
May 27, 2023
Comment thread
Doc/library/typing.rst
Outdated
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
AlexWaygood
reviewed
May 27, 2023
AlexWaygood
approved these changes
May 27, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 060277d)
This backports some of the changes from the PEP 695 documentation PR (#104642) to 3.11, because I ended up making some improvements that are also applicable to older versions of typing:
📚 Documentation preview 📚: https://cpython-previews--105007.org.readthedocs.build/