FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CI: Precompute hash for config cache key in check_source job by itamaro · Pull Request #105008 · python/cpython · GitHub

/ cpython Public

CI: Precompute hash for config cache key in check_source job - #105008

Merged
hugovk merged 1 commit into
python:mainfrom
itamaro:precompute-config-hash
May 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

CI: Precompute hash for config cache key in check_source job#105008
hugovk merged 1 commit into
python:mainfrom
itamaro:precompute-config-hash

Conversation

itamaro commented May 27, 2023

Copy link
Copy Markdown
Contributor

Followup to gh-104800, since all the build jobs already depend on the check_source job, we can precompute the hash in that job and reuse it in the downstream jobs.

While the time saving is negligible, the main benefit of this change is that the list of hashed files is not repeated in multiple places.

itamaro mentioned this pull request May 27, 2023
Merged
hugovk approved these changes May 27, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nicely done, thanks!

hugovk merged commit 949f0f5 into python:main May 27, 2023
hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 27, 2023

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @itamaro and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.11

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry @itamaro and @hugovk, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.12

hugovk commented May 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@itamaro Please could you backport these to 3.12 and 3.11?

hugovk added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 27, 2023

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105014 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
CI: Precompute hash for config cache key in check_source job (pythonG…
a6c1b67 
…H-105008)

(cherry picked from commit 949f0f5)

Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
hugovk mentioned this pull request May 27, 2023
Merged
hugovk pushed a commit that referenced this pull request May 27, 2023
[3.12] CI: Precompute hash for config cache key in check_source job (G…
edd0cb8 
…H-105008) (#105014)

Co-authored-by: Itamar Ostricher <itamarost@gmail.com>

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105024 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
itamaro mentioned this pull request May 27, 2023
Merged
itamaro added a commit to itamaro/cpython that referenced this pull request May 27, 2023
[3.11] CI: Precompute hash for config cache key in check_source job (p…
40532b0 
…ythonGH-105008)

Backport of pythongh-105014 to 3.11

(manually cherry picked from commit 949f0f5)
hugovk pushed a commit that referenced this pull request May 27, 2023
[3.11] CI: Precompute hash for config cache key in check_source job (G…
d1a7d66 
…H-105008) (#105024)

erlend-aasland commented May 29, 2023

Copy link
Copy Markdown
Contributor

Nice; thanks!

erlend-aasland mentioned this pull request Jun 6, 2023
Closed
itamaro deleted the precompute-config-hash branch April 9, 2024 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL