FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105013: Fix inspect.getsource with parenthesized multiline lambdas by pablogsal · Pull Request #105021 · python/cpython · GitHub

/ cpython Public

gh-105013: Fix inspect.getsource with parenthesized multiline lambdas - #105021

Merged
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-105013
May 27, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-105013: Fix inspect.getsource with parenthesized multiline lambdas#105021
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-105013

Conversation

pablogsal commented May 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 27, 2023
Closed
pablogsal requested a review from lysnikolaou May 27, 2023 15:58
pablogsal added the needs backport to 3.12 only security fixes label May 27, 2023
fixup! pythongh-105013: Fix inspect.getsource with parenthesized mult…
9b9d810 
…iline lambdas

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
arhadthedev reviewed May 27, 2023
View reviewed changes
Comment thread Lib/test/inspect_fodder2.py Outdated
sunmy2019 reviewed May 27, 2023
View reviewed changes
Comment thread Lib/inspect.py
Comment thread Lib/test/inspect_fodder2.py Outdated
pablogsal merged commit 3a5be87 into python:main May 27, 2023
pablogsal deleted the gh-105013 branch May 27, 2023 23:20

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
pythongh-105013: Fix inspect.getsource with parenthesized multiline l…
da6274b 
…ambdas (pythonGH-105021)

(cherry picked from commit 3a5be87)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105032 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023

bedevere-bot commented May 28, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit 3a5be87.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/3442) and take a look at the build logs.
  4. Check if the failure is related to this commit (3a5be87) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/3442

Failed tests:

  • test_tools

Failed subtests:

  • test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script
  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

430 tests OK.

10 slowest tests:

  • test_tools: 5 min 28 sec
  • test_gdb: 2 min 21 sec
  • test_concurrent_futures: 2 min 13 sec
  • test_multiprocessing_spawn: 1 min 29 sec
  • test_signal: 1 min 16 sec
  • test_multiprocessing_forkserver: 1 min 11 sec
  • test_multiprocessing_fork: 1 min 7 sec
  • test_socket: 43.3 sec
  • test_io: 33.8 sec
  • test_imaplib: 31.8 sec

1 test failed:
test_tools

16 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_ioctl
test_kqueue test_launcher test_perf_profiler test_readline
test_startfile test_tkinter test_ttk test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

2 re-run tests:
test.test_asyncio.test_subprocess test_tools

Total duration: 13 min 5 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/tmpp5ax66v2/cpython/Lib/sysconfig.py", line 740, in get_config_var
    return get_config_vars().get(name)
           ^^^^^^^^^^^^^^^^^
  File "/tmp/tmpp5ax66v2/cpython/Lib/sysconfig.py", line 723, in get_config_vars
    _init_config_vars()
  File "/tmp/tmpp5ax66v2/cpython/Lib/sysconfig.py", line 670, in _init_config_vars
    _init_posix(_CONFIG_VARS)
  File "/tmp/tmpp5ax66v2/cpython/Lib/sysconfig.py", line 536, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_sysconfigdata__linux_s390x-linux-gnu'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[69 chars]), 'process_exited', 'pipe_connection_lost', '[17 chars]ost'] != [('pi[69 chars]), 'pipe_connection_lost', 'pipe_connection_lo[17 chars]ted']


Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/test_python_m88f8cj4/tmpuk19wcv2/cpython/Lib/sysconfig.py", line 740, in get_config_var
    return get_config_vars().get(name)
           ^^^^^^^^^^^^^^^^^
  File "/tmp/test_python_m88f8cj4/tmpuk19wcv2/cpython/Lib/sysconfig.py", line 723, in get_config_vars
    _init_config_vars()
  File "/tmp/test_python_m88f8cj4/tmpuk19wcv2/cpython/Lib/sysconfig.py", line 670, in _init_config_vars
    _init_posix(_CONFIG_VARS)
  File "/tmp/test_python_m88f8cj4/tmpuk19wcv2/cpython/Lib/sysconfig.py", line 536, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_sysconfigdata__linux_s390x-linux-gnu'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 180, in prepare
    _run_quiet([MAKE, '-C', builddir, parallel])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 25, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/tmpp5ax66v2/python-build', '-j2']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 180, in prepare
    _run_quiet([MAKE, '-C', builddir, parallel])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 25, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_m88f8cj4/tmpuk19wcv2/python-build', '-j2']' returned non-zero exit status 2.

pablogsal added a commit that referenced this pull request May 28, 2023
[3.12] gh-105013: Fix inspect.getsource with parenthesized multiline …
41b622b 
…lambdas (GH-105021) (#105032)

gh-105013: Fix inspect.getsource with parenthesized multiline lambdas (GH-105021)
(cherry picked from commit 3a5be87)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal mentioned this pull request May 28, 2023
Closed
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

arhadthedev arhadthedev left review comments
sunmy2019 sunmy2019 left review comments
lysnikolaou Awaiting requested review from lysnikolaou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL