FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105017: Fix including additional NL token when using CRLF by mgmacias95 · Pull Request #105022 · python/cpython · GitHub

/ cpython Public

gh-105017: Fix including additional NL token when using CRLF - #105022

Merged
pablogsal merged 4 commits into
python:mainfrom
mgmacias95:fix_additional_nl
May 27, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-105017: Fix including additional NL token when using CRLF#105022
pablogsal merged 4 commits into
python:mainfrom
mgmacias95:fix_additional_nl

Conversation

mgmacias95 commented May 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 27, 2023
Closed
pablogsal approved these changes May 27, 2023
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Great work ✨

pablogsal added needs backport to 3.12 only security fixes and removed awaiting merge labels May 27, 2023
pablogsal enabled auto-merge (squash) May 27, 2023 16:26
pablogsal merged commit 86d8f48 into python:main May 27, 2023

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @mgmacias95 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105023 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
pythongh-105017: Fix including additional NL token when using CRLF (p…
1c7e37d 
…ythonGH-105022)

(cherry picked from commit 86d8f48)

Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
pablogsal added a commit that referenced this pull request May 27, 2023
[3.12] gh-105017: Fix including additional NL token when using CRLF (G…
2b176bc 
…H-105022) (#105023)

Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL