FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89886: Rely on HAVE_SYS_TIME_H by erlend-aasland · Pull Request #105058 · python/cpython · GitHub

Repository navigation

gh-89886: Rely on HAVE_SYS_TIME_H - #105058

Merged
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sys/time.h
Jun 1, 2023
Merged

erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sys/time.h

Conversation

erlend-aasland commented May 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Quoting autoupdate (v2.71):

All current systems provide time.h; it need not be checked for.
Not all systems provide sys/time.h, but those that do, all allow
you to include it and time.h simultaneously.

Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de000c6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023

Copy link
Copy Markdown
Contributor Author

On hold until test_import and test_peg_generator issues have been resolved on main.

Comment thread Modules/expat/xmlparse.c Outdated
Comment thread configure.ac Outdated
Comment thread configure.ac Outdated

Copy link
Copy Markdown
Contributor Author

Ok, I think we can land this now. Thanks for the review! It helps with more eyes 👀

erlend-aasland merged commit 9ab587b into python:main Jun 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

erlend-aasland deleted the sys/time.h branch June 1, 2023 11:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2023
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Copy link
Copy Markdown

GH-105192 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 1, 2023
erlend-aasland added a commit that referenced this pull request Jun 1, 2023
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.

(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL