Clarify that error messages are better with PEP 701 - #105150
Merged
pablogsal merged 6 commits intoMay 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mgmacias95
reviewed
May 31, 2023
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Copy link
Copy Markdown
Contributor
|
For some reason the code is not highlighted in the preview docs: Is this expected? The other syntax error blocks have the code higlighted: |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Seems that the lexer in sphinx has problems with the $ in the example. I will replace this by another kind of syntax error:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2023
(cherry picked from commit 60cfc6d) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Copy link
Copy Markdown
|
GH-105169 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
hugovk
pushed a commit
that referenced
this pull request
Jun 5, 2023
#105169) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--105150.org.readthedocs.build/