FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal by iritkatriel · Pull Request #105195 · python/cpython · GitHub

/ cpython Public

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal - #105195

Merged
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:immortals-doc
Jun 21, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal#105195
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:immortals-doc

Conversation

iritkatriel commented Jun 1, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

iritkatriel added the needs backport to 3.12 only security fixes label Jun 1, 2023
bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 1, 2023
bedevere-bot mentioned this pull request Jun 1, 2023
Closed

iritkatriel commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

CC @eduardo-elizondo .

eduardo-elizondo mentioned this pull request Jun 4, 2023
Closed
corona10 mentioned this pull request Jun 5, 2023
Merged
JelleZijlstra previously requested changes Jun 5, 2023
View reviewed changes
Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/bool.rst Outdated

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

iritkatriel commented Jun 5, 2023
View reviewed changes
Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/none.rst Outdated
Comment thread Doc/c-api/slice.rst Outdated

iritkatriel commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Jun 21, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland, @JelleZijlstra: please review the changes made to this pull request.

carljm reviewed Jun 21, 2023
View reviewed changes

carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, just a few more broken references to fix.

Since bool.rst is such a small file I'd be tempted to also just fix in passing the two erroring references to Py_True and Py_False near the top of the file (line 9), but that's up to you; that line isn't changed in the PR otherwise.

Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/bool.rst Outdated
Comment thread Doc/c-api/slice.rst Outdated
iritkatriel and others added 2 commits June 21, 2023 19:12
Apply suggestions from code review
7330a7f 
Co-authored-by: Carl Meyer <carl@oddbird.net>
fix :const:->:c:data:
4281b5b
iritkatriel dismissed JelleZijlstra’s stale review June 21, 2023 20:12

Changes made and approved by other reviewers.

iritkatriel merged commit a239272 into python:main Jun 21, 2023

miss-islington commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented Jun 21, 2023

Copy link
Copy Markdown

GH-105977 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2023
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
4446a42 
…ecoming immortal (pythonGH-105195)

(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
40a23a1 
…ecoming immortal (python#105195)
kumaraditya303 pushed a commit that referenced this pull request Jun 26, 2023
[3.12] gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis …
592d1ea 
…becoming immortal (GH-105195) (#105977)

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal (GH-105195)
(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel deleted the immortals-doc branch July 25, 2023 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm carljm approved these changes
erlend-aasland erlend-aasland approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently
JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL