FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105194: Fix format specifier escaped characters in f-strings by pablogsal · Pull Request #105231 · python/cpython · GitHub

/ cpython Public

gh-105194: Fix format specifier escaped characters in f-strings - #105231

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-105194
Jun 2, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-105194: Fix format specifier escaped characters in f-strings#105231
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-105194

Conversation

pablogsal commented Jun 2, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested a review from lysnikolaou as a code owner June 2, 2023 09:38
pablogsal added the needs backport to 3.12 only security fixes label Jun 2, 2023
bedevere-bot mentioned this pull request Jun 2, 2023
Closed
lysnikolaou approved these changes Jun 2, 2023
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Always so fast! 🔫

pablogsal merged commit 41de543 into python:main Jun 2, 2023
pablogsal deleted the gh-105194 branch June 2, 2023 11:33

miss-islington commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
pythongh-105194: Fix format specifier escaped characters in f-strings (…
e32ae2a 
…pythonGH-105231)

(cherry picked from commit 41de543)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

GH-105234 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 2, 2023

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 41de543.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4135) and take a look at the build logs.
  4. Check if the failure is related to this commit (41de543) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/4135

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

427 tests OK.

10 slowest tests:

  • test_compileall: 10 min 33 sec
  • test_venv: 9 min 57 sec
  • test_largefile: 9 min
  • test_multiprocessing_spawn: 4 min 27 sec
  • test_math: 4 min 24 sec
  • test_concurrent_futures: 3 min 1 sec
  • test_hashlib: 2 min 34 sec
  • test_regrtest: 2 min 25 sec
  • test_multiprocessing_forkserver: 1 min 54 sec
  • test_peg_generator: 1 min 53 sec

1 test altered the execution environment:
test.test_asyncio.test_unix_events

19 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 38 min 42 sec

Click to see traceback logs 
remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/16)        
remote: Counting objects:  12% (2/16)        
remote: Counting objects:  18% (3/16)        
remote: Counting objects:  25% (4/16)        
remote: Counting objects:  31% (5/16)        
remote: Counting objects:  37% (6/16)        
remote: Counting objects:  43% (7/16)        
remote: Counting objects:  50% (8/16)        
remote: Counting objects:  56% (9/16)        
remote: Counting objects:  62% (10/16)        
remote: Counting objects:  68% (11/16)        
remote: Counting objects:  75% (12/16)        
remote: Counting objects:  81% (13/16)        
remote: Counting objects:  87% (14/16)        
remote: Counting objects:  93% (15/16)        
remote: Counting objects: 100% (16/16)        
remote: Counting objects: 100% (16/16), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 16 (delta 3), reused 9 (delta 3), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '41de54378d54f7ffc38f07db4219e80f48c4249e'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 41de54378d gh-105194: Fix format specifier escaped characters in f-strings (#105231)
Switched to and reset branch 'main'

./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   62 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:2002: buildbottest] Error 3

pablogsal pushed a commit that referenced this pull request Jun 2, 2023
[3.12] gh-105194: Fix format specifier escaped characters in f-strings (
103ae4e 
GH-105231) (#105234)
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL