gh-98963: Restore the ability to have a dict-less property. - #105262
gh-98963: Restore the ability to have a dict-less property.#105262JelleZijlstra merged 7 commits into
Conversation
Sorry, something went wrong.
Ignore doc string assignment failures in `property` as has been the behavior of all past Python releases. One behavior change: The longstanding tested behavior of raising an `AttributeError` when using a slotted no-dict property subclass as a decorator on a getter sporting a docstring is now consistent with the subclassing behavior and does not produce an error.
This comment was marked as outdated.
JelleZijlstra
left a comment
There was a problem hiding this comment.
This behavior is weird but it's consistent with how 3.11 works, so let's merge it. (Apart from what I think is an extraneous DECREF.)
Sorry, something went wrong.
Yeah... I can't say this is the overall set of behavior anyone would ever choose. I'm mostly aiming for minimum behavior change vs older Pythons so if we ever want to bother with changing this semi-esoteric edge case we can do it in a planned API change fashion. adding that extra code to retain the AttributeError only when the docstring comes from getter.__doc__ feels weird, but that behavior might honestly be what we want in all cases in the long run so removing it as my initial version of this PR did felt unwise as it could lead to people unintentionally writing code that doesn't work across multiple versions if we ever choose to do that. |
Sorry, something went wrong.
|
Thanks @gpshead for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
|
GH-105297 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
…thonGH-105262) Ignore doc string assignment failures in `property` as has been the behavior of all past Python releases. (cherry picked from commit 418befd) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
I wish github would've preserved the much longer commit message I authored for later when auto merge was disabled. :( |
Sorry, something went wrong.
…H-105262) (#105297) gh-98963: Restore the ability to have a dict-less property. (GH-105262) Ignore doc string assignment failures in `property` as has been the behavior of all past Python releases. (the docstring is discarded) (cherry picked from commit 418befd) This fixes a behavior regression in 3.12beta1 where an AttributeError was being raised in a situation it has never been in the past. It keeps the existing unusual single situation where AttributeError does get raised. Existing widely deployed projects depend on this not raising an exception. Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sorry for that! |
Sorry, something went wrong.
Ignore doc string assignment failures in property as has been the behavior of all past Python releases.
Preserves the one situation in which the AttributeError has always been raised for this property subclass situation:
If the docstring would be applied from a getter function it raises rather than remaining silent. (see the existing test and code comments)
This undoes a behavior regression present in 3.12beta1 that was causing existing widely used library code (Google protobuf) to fail.