FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix reference to `parse_args` in `optparse.rst` · Pull Request #105265 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix reference to parse_args in optparse.rst - #105265

Merged
hugovk merged 4 commits into
mainfrom
unknown repository
Jun 28, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-101100: Fix reference to parse_args in optparse.rst#105265
hugovk merged 4 commits into
mainfrom
unknown repository

Conversation

ghost commented Jun 3, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 3, 2023
bedevere-bot mentioned this pull request Jun 3, 2023
Closed
hugovk requested changes Jun 5, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR.

However, this currently updates the links to point to the parse_args method of the argparse module, when it should be pointing to the parse_args method of this optparse module.

The reason we're getting warnings is because the optparse's parse_args doesn't yet have documentation in this optparse.rst file.

It does have a docstring, so that could be used as a starting point for adding it here:

cpython/Lib/optparse.py

Line 1355 in dbc179e

def parse_args(self, args=None, values=None):

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hugovk added the pending The issue will be closed if no feedback is provided label Jun 5, 2023

ghost commented Jun 28, 2023

Copy link
Copy Markdown
Author

I have made the requested changes; please review again.

bedevere-bot commented Jun 28, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-bot requested a review from hugovk June 28, 2023 06:54
hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 28, 2023

hugovk commented Jun 28, 2023

Copy link
Copy Markdown
Member

Thank you!

hugovk merged commit 18f51f9 into python:main Jun 28, 2023

miss-islington commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @F3eQnxN3RriK for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot commented Jun 28, 2023

Copy link
Copy Markdown

GH-106204 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 28, 2023

bedevere-bot commented Jun 28, 2023

Copy link
Copy Markdown

GH-106205 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2023
pythongh-101100: Fix reference to parse_args in optparse.rst (pyt…
5a4cdce 
…honGH-105265)

(cherry picked from commit 18f51f9)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2023
pythongh-101100: Fix reference to parse_args in optparse.rst (pyt…
e9c4303 
…honGH-105265)

(cherry picked from commit 18f51f9)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
ghost deleted the doc-patch-1 branch June 28, 2023 12:32
hugovk pushed a commit that referenced this pull request Jun 28, 2023
[3.11] gh-101100: Fix reference to parse_args in optparse.rst (GH…
ce091c9 
…-105265) (#106205)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
hugovk pushed a commit that referenced this pull request Jun 28, 2023
[3.12] gh-101100: Fix reference to parse_args in optparse.rst (GH…
0cd07b3 
…-105265) (#106204)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL