FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105310: add decorator to skip rerunning tests by sunmy2019 · Pull Request #105311 · python/cpython · GitHub

/ cpython Public

gh-105310: add decorator to skip rerunning tests - #105311

Closed
sunmy2019 wants to merge 2 commits into
python:mainfrom
sunmy2019:gh-105310
ConversationCommits (2)ChecksFiles changed
Closed

gh-105310: add decorator to skip rerunning tests#105311
sunmy2019 wants to merge 2 commits into
python:mainfrom
sunmy2019:gh-105310

Conversation

sunmy2019 commented Jun 5, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Personally, I am not satisfied with the test case added in test_support.py, but I can not figure out something better.

sunmy2019 requested a review from erlend-aasland June 5, 2023 12:26
bedevere-bot mentioned this pull request Jun 5, 2023
Closed
erlend-aasland requested changes Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Outdated

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

sunmy2019 commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Outdated
sunmy2019 commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Outdated

sunmy2019 commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

I think we need news for this one, right?

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

erlend-aasland commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

I think we need news for this one, right?

Well, test changes rarely get their own NEWS items. Personally, I would not bother with it. Related: also note that a lot of the test.support methods intentionally lack docs.

sunmy2019 commented Jun 20, 2023

Copy link
Copy Markdown
Member Author

Closed. See #104796 (comment)

sunmy2019 closed this Jun 20, 2023
sunmy2019 deleted the gh-105310 branch June 23, 2023 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland Awaiting requested review from erlend-aasland

Assignees

No one assigned

Labels

awaiting change review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL