gh-103968: PyType_FromMetaclass: Allow metaclasses with tp_new=NULL - #105386
Merged
encukou merged 2 commits intoJun 12, 2023
Merged
gh-103968: PyType_FromMetaclass: Allow metaclasses with tp_new=NULL#105386encukou merged 2 commits into
encukou merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yes, since it's just relaxing an overly strict check, if we can get it into beta 3 this'd be fine. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2023
…NULL (pythonGH-105386) (cherry picked from commit 2b90796) Co-authored-by: Petr Viktorin <encukou@gmail.com>
Copy link
Copy Markdown
|
GH-105697 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be safe, and useful in some cases, to allow creating types whose metaclass has tp_new=NULL (i.e. the metaclass can't be instantiated from Python).
@Yhg1s, is it OK to backport this to 3.12? (No rush, sorry for bothering you on release day.)
It relaxes a check that newly raises DeprecationWarning in 3.12 (or TypeError from a function that's new in 3.12). It's one line in Objects/typeobject.c, the rest are tests/docs.
📚 Documentation preview 📚: https://cpython-previews--105386.org.readthedocs.build/