FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105375: Improve _pickle error handling by erlend-aasland · Pull Request #105475 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-105375: Improve _pickle error handling - #105475

Merged
erlend-aasland merged 7 commits into
python:mainfrom
erlend-aasland:improve-pickle-error-handling
Jun 9, 2023
ConversationCommits (7)ChecksFiles changed
Merged

gh-105375: Improve _pickle error handling#105475
erlend-aasland merged 7 commits into
python:mainfrom
erlend-aasland:improve-pickle-error-handling

Conversation

erlend-aasland commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Error handling was deferred in some cases, which could potentially lead to exceptions being overwritten.

Issue:

pythongh-105375: Improve _pickle error handling
9b514d5 
Error handling was deferred in some cases, which could potentially lead
to exceptions being overwritten.
Bail early from _Unpickler_SetInputStream() also
a91713a
erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 7, 2023
bedevere-bot mentioned this pull request Jun 7, 2023
Closed
18 tasks done

erlend-aasland commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Slightly uncertain about commit a91713a, since it changes an exception message.

EDIT: I reverted it for now.

kumaraditya303 reviewed Jun 9, 2023
View reviewed changes
Comment thread Modules/_pickle.c
erlend-aasland merged commit 89aac6f into python:main Jun 9, 2023

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

erlend-aasland deleted the improve-pickle-error-handling branch June 9, 2023 17:09

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 89aac6f6b7b3af046ec137121c90732289e79efc 3.12

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 89aac6f6b7b3af046ec137121c90732289e79efc 3.11

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
[3.11] pythongh-105375: Improve _pickle error handling (python#105475)
d5a8288 
(cherry picked from commit 89aac6f)

Error handling was deferred in some cases, which could potentially lead
to exceptions being overwritten.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105583 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 9, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
[3.12] pythongh-105375: Improve _pickle error handling (python#105475)
78dc9de 
(cherry picked from commit 89aac6f)

Error handling was deferred in some cases, which could potentially lead
to exceptions being overwritten.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105584 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 9, 2023
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
[3.11] gh-105375: Improve _pickle error handling (#105475) (#105583)
4d4251d 
(cherry picked from commit 89aac6f)

Error handling was deferred in some cases, which could potentially lead
to exceptions being overwritten.
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
[3.12] gh-105375: Improve _pickle error handling (#105475) (#105584)
04b76ec 
(cherry picked from commit 89aac6f)

Error handling was deferred in some cases, which could potentially lead
to exceptions being overwritten.
erlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks done
serhiy-storchaka reviewed Jun 12, 2023
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this introduced more dangerous bugs in constructors.

Comment thread Modules/_pickle.c
Comment thread Modules/_pickle.c
Comment thread Modules/_pickle.c
erlend-aasland pushed a commit that referenced this pull request Aug 27, 2023
gh-108542: Fix incorrect module name in NEWS entry for gh-105475 (#10…
a429eaf 
…8543)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 27, 2023
[3.12] pythongh-108542: Fix incorrect module name in NEWS entry for p…
9875beb 
…ythongh-105475 (python#108543)

(cherry picked from commit a429eaf)
erlend-aasland added a commit that referenced this pull request Aug 27, 2023
[3.11] gh-108542: Fix incorrect module name in NEWS entry for gh-105475…
73f89b1 
… (#108543) (#108544)

(cherry picked from commit a429eaf)
Yhg1s pushed a commit that referenced this pull request Aug 27, 2023
[3.12] gh-108542: Fix incorrect module name in NEWS entry for gh-105475…
32d48ed 
… (#108543) (#108545)

(cherry picked from commit a429eaf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments
serhiy-storchaka serhiy-storchaka left review comments
kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions

6 participants

Back | FazBrowse Home | New Git URL