FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100227: Lock Around Adding Global Audit Hooks by ericsnowcurrently · Pull Request #105515 · python/cpython · GitHub

/ cpython Public

gh-100227: Lock Around Adding Global Audit Hooks - #105515

Merged
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:audit-hooks-state-granular-lock
Jun 8, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-100227: Lock Around Adding Global Audit Hooks#105515
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:audit-hooks-state-granular-lock

Conversation

ericsnowcurrently commented Jun 8, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The risk of a race with this state is relatively low, but we play it safe anyway.

bedevere-bot mentioned this pull request Jun 8, 2023
Closed
ericsnowcurrently requested a review from zooba June 8, 2023 18:07

zooba commented Jun 8, 2023

Copy link
Copy Markdown
Member

I'd be just as happy with documenting that you need to self-synchronize when using this function. It should only be being called by embedders anyway.

But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that.

ericsnowcurrently commented Jun 8, 2023

Copy link
Copy Markdown
Member Author

But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that.

FWIW, we didn't have one before per-interpreter GIL. I've tried to be consistent, though, as I've been inventing the pattern. 😄

ericsnowcurrently removed the request for review from zooba June 8, 2023 18:32
ericsnowcurrently marked this pull request as ready for review June 8, 2023 18:32
ericsnowcurrently enabled auto-merge (squash) June 8, 2023 18:33
ericsnowcurrently merged commit e822a67 into python:main Jun 8, 2023

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

ericsnowcurrently deleted the audit-hooks-state-granular-lock branch June 8, 2023 18:39
ericsnowcurrently added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 8, 2023

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @ericsnowcurrently, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

ericsnowcurrently added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 8, 2023

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @ericsnowcurrently, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

ericsnowcurrently removed the needs backport to 3.12 only security fixes label Jun 8, 2023
ericsnowcurrently added the needs backport to 3.12 only security fixes label Jun 8, 2023

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @ericsnowcurrently, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 8, 2023
pythongh-100227: Lock Around Adding Global Audit Hooks (pythongh-105515)
986572b 
The risk of a race with this state is relatively low, but we play it safe anyway.

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105525 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2023
[3.12] gh-100227: Lock Around Adding Global Audit Hooks (gh-105515) (g…
b08ea9a 
…h-105525)

The risk of a race with this state is relatively low, but we play it safe anyway.
(cherry picked from commit e822a67)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

ericsnowcurrently

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL