FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105497: [Enum] Fix flag inversion when alias/mask members exist. by ethanfurman · Pull Request #105542 · python/cpython · GitHub

/ cpython Public

gh-105497: [Enum] Fix flag inversion when alias/mask members exist. - #105542

Merged
ethanfurman merged 1 commit into
python:mainfrom
ethanfurman:enum-flag_conform
Jun 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-105497: [Enum] Fix flag inversion when alias/mask members exist.#105542
ethanfurman merged 1 commit into
python:mainfrom
ethanfurman:enum-flag_conform

Conversation

ethanfurman commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
ethanfurman self-assigned this Jun 9, 2023
bedevere-bot mentioned this pull request Jun 9, 2023
Closed
ethanfurman merged commit 59f009e into python:main Jun 9, 2023

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Sorry @ethanfurman, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 59f009e5898a006cdc8f5249be589de6edfe5cd0 3.12

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105571 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 9, 2023
ethanfurman added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 9, 2023

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
pythongh-105497: [Enum] Fix Flag inversion when alias/mask members ex…
fc21528 
…ist. (pythonGH-105542)

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105572 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
pythongh-105497: [Enum] Fix Flag inversion when alias/mask members ex…
9173077 
…ist. (pythonGH-105542)

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman deleted the enum-flag_conform branch June 9, 2023 16:03
ambv pushed a commit that referenced this pull request Jul 5, 2023
[3.12] gh-105497: [Enum] Fix Flag inversion when alias/mask members e…
74d84cf 
…xist. (GH-105542) (#105572)

gh-105497: [Enum] Fix Flag inversion when alias/mask members exist. (GH-105542)

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ambv pushed a commit that referenced this pull request Jul 5, 2023
[3.11] gh-105497: [Enum] Fix Flag inversion when alias/mask members e…
3f244b2 
…xist. (GH-105542) (#105571)

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Eclips4 mentioned this pull request Aug 1, 2023
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

ethanfurman

Labels

3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL