gh-105566: Deprecate unusual ways of creating typing.NamedTuple classes - #105609
Merged
AlexWaygood merged 3 commits intoJun 14, 2023
Merged
gh-105566: Deprecate unusual ways of creating typing.NamedTuple classes#105609AlexWaygood merged 3 commits into
AlexWaygood merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
June 9, 2023 21:29
sobolevn
reviewed
Jun 10, 2023
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good cleanup!
Sorry, something went wrong.
Comment thread
Lib/typing.py
| return '<sentinel>' | ||
|
|
||
|
|
||
| _sentinel = _Sentinel() |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think that = object() is good enough for this case.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I disagree. Using = object() would mean that the displayed signature would be very ugly if somebody did help(typing.NamedTuple) in the REPL
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Also, we'll be able to reuse the _Sentinel class when we do #105570 :)
Sorry, something went wrong.
Comment thread
Doc/library/typing.rst
Outdated
AlexWaygood
commented
Jun 14, 2023
Comment thread
Doc/library/typing.rst
Outdated
Comment thread
Doc/whatsnew/3.13.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2023-06-09-20-34-23.gh-issue-105566.YxlGg1.rst
Outdated
JelleZijlstra
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105566
📚 Documentation preview 📚: https://cpython-previews--105609.org.readthedocs.build/