GH-104584: Assorted fixes for the optimizer API. - #105683
Merged
markshannon merged 10 commits intoJun 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
carljm
reviewed
Jun 12, 2023
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Comment thread
Python/bytecodes.c
Comment thread
Python/bytecodes.c
Outdated
brandtbucher
self-requested a review
June 12, 2023 17:25
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
+1 to all of @carljm's comments.
Sorry, something went wrong.
Comment thread
Objects/codeobject.c
Outdated
Comment thread
Python/optimizer.c
Outdated
Comment thread
Python/optimizer.c
Comment thread
Python/optimizer.c
Outdated
carljm
approved these changes
Jun 15, 2023
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Copy link
Copy Markdown
Member
|
What's holding this up? I was playing around with the optimizer, trying to bootstrap a "hello world" version of a Tier 2 interpreter, and I need this to avoid crashes at exit (crashes that happened even without my changes). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few odds and ends found trying to fix #105682