Repository navigation
GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() and is_file() - #105794
Merged
barneygale merged 7 commits intoJun 26, 2023
Merged
barneygale merged 7 commits into
barneygale merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Brings `pathlib.Path.is_dir()` in line with `os.DirEntry.is_dir()`, which will be important for implementing generic path walking and globbing.
EpicWink
approved these changes
Jun 18, 2023
zooba
approved these changes
Jun 26, 2023
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings pathlib.Path.is_dir() in line with os.DirEntry.is_dir(), likewise is_file(), which will be important for implementing generic path walking and globbing.
📚 Documentation preview 📚: https://cpython-previews--105794.org.readthedocs.build/