Repository navigation
gh-105481: remove HAS_ARG, HAS_CONST, IS_JUMP_OPCODE, IS_PSEUDO_OPCODE and replace by their new versions - #105865
Merged
iritkatriel merged 7 commits intoJun 17, 2023
Merged
iritkatriel merged 7 commits into
iritkatriel merged 7 commits into
Conversation
gvanrossum
approved these changes
Jun 16, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Do we need any doc update for dis.stack_effect (or is it opcode.stack_effect now that it no longer requires the presence of oparg to match the requirements of the opcode.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The doc doesn't mention the arg check issue. Should I add a versionchanged note anyway? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Might as well. |
Sorry, something went wrong.
arhadthedev
reviewed
Jun 17, 2023
Comment thread
Misc/NEWS.d/next/Library/2023-06-17-12-13-57.gh-issue-105481.KgBH5w.rst
Outdated
gvanrossum
approved these changes
Jun 17, 2023
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 18, 2023
…_OPCODE and replace by their new versions (python#105865)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.