FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-105908: fix `barry_as_FLUFL` future import by thatbirdguythatuknownot · Pull Request #105909 · python/cpython · GitHub

/ cpython Public

gh-105908: fix barry_as_FLUFL future import - #105909

Merged
iritkatriel merged 6 commits into
python:mainfrom
thatbirdguythatuknownot:patch-31
Jun 19, 2023
ConversationCommits (6)ChecksFiles changed
Merged

gh-105908: fix barry_as_FLUFL future import#105909
iritkatriel merged 6 commits into
python:mainfrom
thatbirdguythatuknownot:patch-31

Conversation

thatbirdguythatuknownot commented Jun 19, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

In compiler_setup(), the flags parameter is a local struct that does not reflect changes to the pointer passed to new_compiler(). Fix by making the flags parameter a pointer to a struct instead of a struct.

bedevere-bot mentioned this pull request Jun 19, 2023
Closed

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Is there no test for this?

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Is there no test for this?

I'm currently adding it.

fix news markdown
6815da7 
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Thank you @thatbirdguythatuknownot .

iritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 19, 2023

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

It must be from flags = &_PyCompilerFlags_INIT. I could probably bring back the local_flags variable to prevent it.

iritkatriel merged commit 28187a9 into python:main Jun 19, 2023

sunmy2019 commented Jun 20, 2023

Copy link
Copy Markdown
Member

Thanks! This change makes sense.

JelleZijlstra commented Jun 20, 2023

Copy link
Copy Markdown
Member

Does this need to be backported to 3.12?

JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 20, 2023

miss-islington commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @thatbirdguythatuknownot for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented Jun 20, 2023

Copy link
Copy Markdown

GH-105930 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2023
pythongh-105908: fix barry_as_FLUFL future import (pythonGH-105909)
32335a2 
(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
JelleZijlstra pushed a commit that referenced this pull request Jun 20, 2023
[3.12] gh-105908: fix barry_as_FLUFL future import (GH-105909) (#10…
cc18a8b 
…5930)

(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Eclips4 Eclips4 left review comments
iritkatriel iritkatriel approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL