gh-105481: generate _specializations and _specialized_instructions from bytecodes.c - #105913
Merged
iritkatriel merged 9 commits intoJun 19, 2023
Merged
gh-105481: generate _specializations and _specialized_instructions from bytecodes.c#105913iritkatriel merged 9 commits into
iritkatriel merged 9 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 19, 2023 13:27
Copy link
Copy Markdown
Member
|
We should move the optimization in BINARY_OP_INPLACE_ADD_UNICODE to tier 2, once it we have a tier 2 optimizer. It makes sense there, but not in tier 1. |
Sorry, something went wrong.
markshannon
approved these changes
Jun 19, 2023
Comment thread
Lib/importlib/_bootstrap_external.py
Comment thread
Lib/test/test__opcode.py
Outdated
Copy link
Copy Markdown
Member
|
Looks like summarize_stats.py needs updating |
Sorry, something went wrong.
gvanrossum
approved these changes
Jun 19, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. One nit; no need to get another review if you decide to fix that. Also okay to merge as-is.
Sorry, something went wrong.
Comment thread
Makefile.pre.in
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates the metadata about specialised opcodes from bytecodes.c, to replace the hard coded dict in opcode.py.
There is one irregularity that I needed to special-case: BINARY_OP_INPLACE_ADD_UNICODE, which is commented out in bytecodes.c (because it has different stack effect compared to the rest of the family).