gh-105922: Add PyImport_AddModuleRef() function - #105923
Merged
vstinner merged 1 commit intoJun 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
requested review from
a team,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 19, 2023 18:03
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice; I left some comments.
Too bad we cannot run the ref leak bots now; there's already a ref leak in test_import and test_peg_generator that has not been resolved :(
Sorry, something went wrong.
Comment thread
Include/import.h
Comment thread
Misc/NEWS.d/next/C API/2023-06-19-20-02-16.gh-issue-105922.o4T6wO.rst
Outdated
Comment thread
Python/import.c
Outdated
Comment thread
Python/import.c
Outdated
Comment thread
Python/pythonrun.c
Outdated
vstinner
force-pushed
the
pyimport_addmoduleref
branch
from
631c02c to
bf2a756
Compare
June 19, 2023 23:08
Copy link
Copy Markdown
Member
Author
|
I updated my PR:
|
Sorry, something went wrong.
erlend-aasland
approved these changes
Jun 19, 2023
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Small typo nit. Otherwise looks good to me.
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.13.rst
Outdated
Comment thread
Misc/NEWS.d/next/C API/2023-06-19-20-02-16.gh-issue-105922.o4T6wO.rst
Outdated
* Add tests on PyImport_AddModuleRef(), PyImport_AddModule() and PyImport_AddModuleObject(). * pythonrun.c: Replace Py_XNewRef(PyImport_AddModule(name)) with PyImport_AddModuleRef(name).
Copy link
Copy Markdown
Member
Author
|
I fixed the typo: similar than => similar to. |
Sorry, something went wrong.
vstinner
force-pushed
the
pyimport_addmoduleref
branch
from
22c5f8c to
f3a223d
Compare
June 20, 2023 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyImport_AddModuleObject().
PyImport_AddModuleRef(name).
📚 Documentation preview 📚: https://cpython-previews--105923.org.readthedocs.build/