gh-98931: Add custom error messages to invalid import/from with multiple targets - #105985
Merged
pablogsal merged 2 commits intoJun 22, 2023
Merged
gh-98931: Add custom error messages to invalid import/from with multiple targets#105985pablogsal merged 2 commits into
pablogsal merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Author
|
@Yhg1s This is technically not a new error message but somehow an oversight (multiple targets were not supported). Are you ok adding this to 3.12? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yeah, 👍 for getting this into 3.12b4. |
Sorry, something went wrong.
Yhg1s
approved these changes
Jun 22, 2023
… multiple targets Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
AlexWaygood
reviewed
Jun 22, 2023
Comment thread
Misc/NEWS.d/next/Core and Builtins/2023-06-22-14-19-17.gh-issue-98931.PPgvSF.rst
Outdated
…e-98931.PPgvSF.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 22, 2023
… multiple targets (pythonGH-105985) (cherry picked from commit 13237a2) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
GH-105991 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
pablogsal
added a commit
that referenced
this pull request
Jun 22, 2023
bentasker
pushed a commit
to bentasker/cpython
that referenced
this pull request
Jun 23, 2023
… multiple targets (python#105985) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.