gh-105922: Use PyImport_AddModuleRef() function - #105999
Merged
vstinner merged 1 commit intoJun 22, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace PyImport_AddModuleObject() + Py_XNewRef() with PyImport_AddModuleRef() to get directly a strong reference.
vstinner
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 22, 2023 20:33
Copy link
Copy Markdown
Member
Author
|
test_threading failed with a warning on the Address sanitizer CI: test_4_daemon_threads (test.test_threading.ThreadJoinOnShutdown.test_4_daemon_threads) ... ok
test_clear_threads_states_after_fork (test.test_threading.ThreadJoinOnShutdown.test_clear_threads_states_after_fork) ... ok
test_reinit_tls_after_fork (test.test_threading.ThreadJoinOnShutdown.test_reinit_tls_after_fork) ... Warning -- Uncaught thread exception: AssertionError
Exception in thread Thread-36 (do_fork_and_wait):
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/threading.py", line 1052, in _bootstrap_inner
self.run()
File "/home/runner/work/cpython/cpython/Lib/threading.py", line 989, in run
self._target(*self._args, **self._kwargs)
File "/home/runner/work/cpython/cpython/Lib/test/test_threading.py", line 1173, in do_fork_and_wait
support.wait_process(pid, exitcode=50)
File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2156, in wait_process
raise AssertionError(f"process {pid} is still running "
AssertionError: process 21364 is still running after 300.3 seconds
ok
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PyImport_AddModuleObject() + Py_XNewRef() with PyImport_AddModuleRef() to get directly a strong reference.