gh-105927: _ssl GET_SOCKET() uses _PyWeakref_GET_REF() - #106002
Merged
vstinner merged 1 commit intoJun 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Author
|
I started hacking _ssl.c to use a strong reference, but the code is more complicated than what I expected. GET_SOCKET() returns NULL if there is no socket, None is the weak reference is dead, or a borrowed reference to the socket otherwise. It's not easy to migrate the code to strong references. So I only changed GET_SOCKET() but it still returns a borrowed reference. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.