gh-106123: Modules/_sha3 appears to no longer be necessary - #106124
Merged
hauntsaninja merged 2 commits intoJun 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
approved these changes
Jun 26, 2023
Copy link
Copy Markdown
Contributor
|
Thanks, Skip! Can you do a make regen-configure and commit the changes? |
Sorry, something went wrong.
sunmy2019
approved these changes
Jun 27, 2023
sunmy2019
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
hauntsaninja
approved these changes
Jun 27, 2023
hauntsaninja
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks like it was indeed removed in #103597
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @smontanaro for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2023
…honGH-106124) (cherry picked from commit 0345b0c) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Copy link
Copy Markdown
|
GH-106127 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
hauntsaninja
pushed a commit
that referenced
this pull request
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty trivial PR. I'm guessing Modules/_sha3 was a holdover from before Modules/_hacl existed. Perhaps there's a valid reason for it to still exist (used on another platform?), but if so, maybe it should be described in a comment in configure.ac