FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104584: Fix assert in DEOPT macro -- should fix buildbot by gvanrossum · Pull Request #106131 · python/cpython · GitHub

/ cpython Public

gh-104584: Fix assert in DEOPT macro -- should fix buildbot - #106131

Merged
gvanrossum merged 1 commit into
python:mainfrom
gvanrossum:fix-deopt
Jun 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-104584: Fix assert in DEOPT macro -- should fix buildbot#106131
gvanrossum merged 1 commit into
python:mainfrom
gvanrossum:fix-deopt

Conversation

gvanrossum commented Jun 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

That's what I get for not running all buildbots for gh-105924.

gvanrossum requested a review from markshannon June 27, 2023 04:41
bedevere-bot mentioned this pull request Jun 27, 2023
Closed
gvanrossum merged commit bb578a0 into python:main Jun 27, 2023
gvanrossum deleted the fix-deopt branch June 27, 2023 14:02

markshannon commented Jun 27, 2023

Copy link
Copy Markdown
Member

There are a lot of warnings, as opcode is a uint8_t in the tier1 interpreter, so opcode >= 256 is always false.
Maybe redefine DEOPT_IF for the uop interpreter, with a different assert?

bedevere-bot commented Jun 27, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit bb578a0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/5583) and take a look at the build logs.
  4. Check if the failure is related to this commit (bb578a0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/5583

Failed tests:

  • test_concurrent_futures

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

415 tests OK.

10 slowest tests:

  • test_math: 5 min 7 sec
  • test_multiprocessing_spawn: 4 min 29 sec
  • test_capi: 2 min 24 sec
  • test_wmi: 2 min 14 sec
  • test_mmap: 2 min 4 sec
  • test_peg_generator: 2 min 4 sec
  • test_tokenize: 1 min 58 sec
  • test_io: 1 min 51 sec
  • test_unparse: 1 min 49 sec
  • test_unicodedata: 1 min 35 sec

31 tests skipped:
test.test_asyncio.test_unix_events test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_openpty test_perf_profiler
test_perfmaps test_poll test_posix test_pty test_pwd test_readline
test_resource test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64 test_zoneinfo

1 re-run test:
test_concurrent_futures

Total duration: 22 min 12 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 822, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 752, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 531, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 485, in temp_dir
    rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 442, in rmtree
    _rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 385, in _rmtree


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 207, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_4948�\\test_python_worker_3704�'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 480, in temp_dir
    yield path
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 533, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 758, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 817, in _main
    sys.exit(0)
SystemExit: 0

gvanrossum commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

There are a lot of warnings, as opcode is a uint8_t in the tier1 interpreter, so opcode >= 256 is always false. Maybe redefine DEOPT_IF for the uop interpreter, with a different assert?

Oh dang. Of course it is. On it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL