GH-104584: Fix ENTER_EXECUTOR - #106141
Merged
markshannon merged 5 commits intoJul 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gvanrossum
reviewed
Jun 27, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The block headed by // Equivalent to CHECK_EVAL_BREAKER() in _PyUopExecute() towards the end of ceval.c can now also safely be replaced with a call to CHECK_EVAL_BREAKER().
Sorry, something went wrong.
gvanrossum
approved these changes
Jul 3, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Gotta merge (the dreaded make regen-cases), otherwise LGTM. I could use this for one of my further UOP PRs.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you merge this? Or are you planning to run buildbots first? |
Sorry, something went wrong.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the eval-breaker is checked and frame->prev_instr updated before entering executors.
No test changes, or news, as there doesn't seem a way to show that anything is broken.