gh-104584: Emit macro expansions to opcode_metadata.h - #106163
Merged
gvanrossum merged 5 commits intoJun 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This would be simpler if the numeric opcode values were generated by generate_cases.py.
(Why can't I run this locally on macOS?)
gvanrossum
marked this pull request as draft
June 28, 2023 05:24
Copy link
Copy Markdown
Member
Author
|
I plan to try the refactor mentioned in the TODO in write_macro_expansions(). |
Sorry, something went wrong.
gvanrossum
marked this pull request as ready for review
June 28, 2023 18:00
Copy link
Copy Markdown
Member
Author
|
I'm just going to merge this once tests pass. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This produces longer traces.
Also improved debug output (uop names are now printed).