FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106145: Make `end_{lineno,col_offset}` required on `type_param` nodes by sobolevn · Pull Request #106224 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-106145: Make end_{lineno,col_offset} required on type_param nodes - #106224

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
sobolevn:issue-106145
Jun 30, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-106145: Make end_{lineno,col_offset} required on type_param nodes#106224
JelleZijlstra merged 2 commits into
python:mainfrom
sobolevn:issue-106145

Conversation

sobolevn commented Jun 29, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I've also added test_type_alias.py to test_unparse to make sure that this new syntax works correctly with ast.unparse.

sobolevn requested a review from JelleZijlstra June 29, 2023 06:48
bedevere-bot mentioned this pull request Jun 29, 2023
Closed
lysnikolaou approved these changes Jun 29, 2023
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

JelleZijlstra reviewed Jun 30, 2023
View reviewed changes
Comment thread Lib/test/test_unparse.py Outdated
JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 30, 2023
JelleZijlstra self-assigned this Jun 30, 2023
JelleZijlstra enabled auto-merge (squash) June 30, 2023 23:15
JelleZijlstra merged commit 46c1097 into python:main Jun 30, 2023

miss-islington commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
pythongh-106145: Make end_{lineno,col_offset} required on `type_par…
36b296a 
…am` nodes (pythonGH-106224)

(cherry picked from commit 46c1097)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jun 30, 2023

Copy link
Copy Markdown

GH-106295 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 30, 2023
JelleZijlstra pushed a commit that referenced this pull request Jul 1, 2023
[3.12] gh-106145: Make end_{lineno,col_offset} required on `type_pa…
0616c83 
…ram` nodes (GH-106224) (#106295)

gh-106145: Make `end_{lineno,col_offset}` required on `type_param` nodes (GH-106224)
(cherry picked from commit 46c1097)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
manosriram pushed a commit to manosriram/cpython that referenced this pull request Jul 1, 2023
pythongh-106145: Make end_{lineno,col_offset} required on `type_par…
ea9c4ff 
…am` nodes (python#106224)
jacobtylerwalls added a commit to jacobtylerwalls/typeshed that referenced this pull request Dec 26, 2023
Make attributes required on AST type_param classes
2fbff73 
Refs python/cpython#106224
jacobtylerwalls mentioned this pull request Dec 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
lysnikolaou lysnikolaou approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL