Repository navigation
gh-101100: Docs: Fix references to several numeric dunders - #106278
Merged
AlexWaygood merged 6 commits intoJun 30, 2023
Merged
AlexWaygood merged 6 commits into
AlexWaygood merged 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
``__index__``, ``__int__``, ``__float__``, ``__complex__`` are methods of ``object``, so prepended `~object` to reference correctly.
AlexWaygood
reviewed
Jun 30, 2023
Comment thread
Doc/library/functions.rst
Outdated
AlexWaygood
reviewed
Jun 30, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A few small nits, but looks great overall. Thanks!
Sorry, something went wrong.
Comment thread
Doc/c-api/complex.rst
Outdated
Comment thread
Doc/c-api/float.rst
Outdated
Comment thread
Doc/library/functions.rst
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Jun 30, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @F3eQnxN3RriK for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2023
…honGH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
GH-106281 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2023
…honGH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
GH-106282 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
ghost
deleted the
doc-patch-2
branch
June 30, 2023 22:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__index__, __int__, __float__, __complex__ are documented as methods of object, so prepended ~object to reference correctly.
📚 Documentation preview 📚: https://cpython-previews--106278.org.readthedocs.build/