FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106310 - document the __signature__ attribute by Gouvernathor · Pull Request #106311 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-106310 - document the __signature__ attribute - #106311

Merged
ncoghlan merged 2 commits into
python:mainfrom
Gouvernathor:patch-6
Oct 20, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-106310 - document the __signature__ attribute#106311
ncoghlan merged 2 commits into
python:mainfrom
Gouvernathor:patch-6

Conversation

Gouvernathor commented Jul 1, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

The inspect.unwrap entry already makes clear that wrappers over a signatured function are recognized.

Maybe it would be worth adding a .. versionadded:: entry, I'm not sure, but in that case I don't know what version I should target.

📚 Documentation preview 📚: https://cpython-previews--106311.org.readthedocs.build/

bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 1, 2023
bedevere-bot mentioned this pull request Jul 1, 2023
Closed

ncoghlan commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

There's an existing version added note for 3.3 for the entire Signature subsection in the inspect docs, so there is no need to add one for this specifically.

ncoghlan approved these changes Oct 20, 2023
View reviewed changes

ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks!

ncoghlan added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 20, 2023
ncoghlan merged commit b07f232 into python:main Oct 20, 2023

miss-islington-app Bot commented Oct 20, 2023

Copy link
Copy Markdown

Thanks @Gouvernathor for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
pythongh-106310 - document the __signature__ attribute (pythonGH-106311)
5048628 
Document the __signature__ attribute

(cherry picked from commit b07f232)

Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
pythongh-106310 - document the __signature__ attribute (pythonGH-106311)
cd678d6 
Document the __signature__ attribute

(cherry picked from commit b07f232)

Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented Oct 20, 2023

Copy link
Copy Markdown

GH-111145 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 20, 2023

bedevere-app Bot commented Oct 20, 2023

Copy link
Copy Markdown

GH-111146 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 20, 2023
Gouvernathor deleted the patch-6 branch October 20, 2023 23:05

Gouvernathor commented Oct 20, 2023

Copy link
Copy Markdown
Contributor Author

Thanks ! 🎉

hugovk pushed a commit that referenced this pull request Oct 23, 2023
[3.12] gh-106310 - document the __signature__ attribute (GH-106311) (#…
6a5aab0 
…111145)

Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk pushed a commit that referenced this pull request Oct 23, 2023
[3.11] gh-106310 - document the __signature__ attribute (GH-106311) (#…
135d5c5 
…111146)

Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-106310 - document the __signature__ attribute (python#106311)
509e24d 
Document the __signature__ attribute

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
skirpichev mentioned this pull request Feb 26, 2024
Closed

skirpichev commented Feb 26, 2024

Copy link
Copy Markdown
Member

See #115937

Gouvernathor mentioned this pull request Feb 29, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-106310 - document the __signature__ attribute (python#106311)
cc29eb4 
Document the __signature__ attribute

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan approved these changes
brettcannon Awaiting requested review from brettcannon
1st1 Awaiting requested review from 1st1
larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL