gh-106217: Truncate the issue body size of new-bugs-announce-notifier - #106329
gh-106217: Truncate the issue body size of new-bugs-announce-notifier#106329hugovk merged 2 commits into
Conversation
hugovk
left a comment
There was a problem hiding this comment.
See also python/core-workflow#456.
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* main: (167 commits) pythongh-91053: make func watcher tests resilient to other func watchers (python#106286) pythongh-104050: Add more type hints to Argument Clinic DSLParser() (python#106354) pythongh-106359: Fix corner case bugs in Argument Clinic converter parser (python#106361) pythongh-104146: Remove unused attr 'parameter_indent' from clinic.DLParser (python#106358) pythongh-106320: Remove private _PyErr C API functions (python#106356) pythongh-104050: Annotate Argument Clinic DSLParser attributes (python#106357) pythongh-106320: Create pycore_modsupport.h header file (python#106355) pythongh-106320: Move _PyUnicodeWriter to the internal C API (python#106342) pythongh-61215: New mock to wait for multi-threaded events to happen (python#16094) Document PYTHONSAFEPATH along side -P (python#106122) Replace the esoteric term 'datum' when describing dict comprehensions (python#106119) pythongh-104050: Add more type hints to Argument Clinic DSLParser() (python#106343) pythongh-106320: _testcapi avoids private _PyUnicode_EqualToASCIIString() (python#106341) pythongh-106320: Add pycore_complexobject.h header file (python#106339) pythongh-106078: Move DecimalException to _decimal state (python#106301) pythongh-106320: Use _PyInterpreterState_GET() (python#106336) pythongh-106320: Remove private _PyInterpreterState functions (python#106335) pythongh-104922: Doc: add note about PY_SSIZE_T_CLEAN (python#106314) pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106329) pythongh-104922: remove PY_SSIZE_T_CLEAN (python#106315) ...
|
It seems that now there is no body for any message sent via the notifier after this change. See the new-bugs-announce archives for issue 106333 (has body) vs 106334 (no body) |
Sorry, something went wrong.
|
Aha, looking at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring, the args are: substring(indexStart)
substring(indexStart, indexEnd)
So: issue.data.body.substring(8000)is attempting to get the substring from char number 8000 up to the end, meaning we lose the first 8000 chars, and get an empty string if there's nothing beyond that. For example: const str = 'Mozilla';
console.log(str.substring(4));
// prints "lla"
console.log(str.substring(8000));
// prints ""Instead we want something like issue.data.body.substring(0, 8000) for the substring from 0 up to 8000. console.log(str.substring(0, 4));
// "Mozi"
console.log(str.substring(0, 8000));
// "Mozilla"Does that look right? Would you like to make a new PR? |
Sorry, something went wrong.
|
Oh my, js strikes again 🤦 |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.