FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106368: Increase Argument Clinic test coverage by erlend-aasland · Pull Request #106369 · python/cpython · GitHub

/ cpython Public

gh-106368: Increase Argument Clinic test coverage - #106369

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/expand-param-state-tests
Jul 3, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-106368: Increase Argument Clinic test coverage#106369
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/expand-param-state-tests

Conversation

erlend-aasland commented Jul 3, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Add tests for 'self' and 'defining_class' converter requirements.

pythongh-106368: Increase Argument Clinic test coverage
afe91ca 
Add tests for 'self' and 'defining_class' converter requirements.
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 3, 2023
bedevere-bot mentioned this pull request Jul 3, 2023
Closed
erlend-aasland enabled auto-merge (squash) July 3, 2023 19:46

erlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

I consider this an uncontroversial change; will merge when CI is green.

sobolevn approved these changes Jul 3, 2023
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you :)

erlend-aasland merged commit 7f4c812 into python:main Jul 3, 2023

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f4c8121db62a9f72f00f2d9f73381e82f289581 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106369
e0f4ef0 
)

Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)

Co-authored-by: Erlend E. Aasland <erlend@python.org>

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106370 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 3, 2023
erlend-aasland deleted the clinic/expand-param-state-tests branch July 3, 2023 20:33

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106374 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 3, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 3, 2023
[3.11] pythongh-106368: Increase Argument Clinic test coverage (pytho…
2899599 
…n#106369)

Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
[3.12] gh-106368: Increase Argument Clinic test coverage (GH-106369) (#…
ddff473 
…106370)

Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
[3.11] gh-106368: Increase Argument Clinic test coverage (#106369) (#…
52d5049 
…106374)

Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn approved these changes

Assignees

erlend-aasland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL