FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-106360: Support very basic superblock introspection by markshannon · Pull Request #106422 · python/cpython · GitHub

/ cpython Public

GH-106360: Support very basic superblock introspection - #106422

Merged
markshannon merged 6 commits into
python:mainfrom
faster-cpython:superblock-introspection
Jul 4, 2023
ConversationCommits (6)ChecksFiles changed
Merged

GH-106360: Support very basic superblock introspection#106422
markshannon merged 6 commits into
python:mainfrom
faster-cpython:superblock-introspection

Conversation

markshannon commented Jul 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Adds indexing and len() support to uop superblocks, such that this:

def testfunc(x):
    i = 0
    while i < x:
        i += 1

testfunc(100)

for offset in range(0, 100, 2):
    try:
        ex = _testinternalcapi.get_executor(testfunc.__code__, offset)
        break
    except ValueError:
        pass

for uop in ex:
    print(uop)

produces this

('SAVE_IP', 7)
('LOAD_FAST', 1)
('SAVE_IP', 8)
('LOAD_CONST', 2)
('SAVE_IP', 9)
('_GUARD_BOTH_INT', 13)
('_BINARY_OP_ADD_INT', 13)
('SAVE_IP', 11)
('STORE_FAST', 1)
('SAVE_IP', 12)
('LOAD_FAST', 1)
('LOAD_FAST', 0)
('SAVE_IP', 13)
('COMPARE_OP_INT', 18)
('SAVE_IP', 15)

bedevere-bot mentioned this pull request Jul 4, 2023
Closed
markshannon requested a review from gvanrossum July 4, 2023 15:18

markshannon commented Jul 4, 2023

Copy link
Copy Markdown
Member Author

This PR also adds _PyOpcode_OpName and _PyOpcode_uop_name to non-debug builds because they are only a few Kbs of static data, and it is nice to be able to introspect things.

gvanrossum approved these changes Jul 4, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This just needs a merge.

In the light of rising concerns over symbols starting with _Py still being public, maybe we should rename these or move the header file? These tables should be allowed to change on a whim.

Comment thread Lib/test/test_capi/test_misc.py Outdated
pass
if ex is None:
return
self.assertIn("SET_IP", str(ex))

gvanrossum Jul 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think once you merge main you'll see that this is now called SAVE_IP.

markshannon commented Jul 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

In the light of rising concerns over symbols starting with _Py still being public.

They aren't public though. We strip _Py symbols from the binary, unless they are marked with a PyAPI_FUNC or PyAPI_DATA macro.

markshannon merged commit 318ea2c into python:main Jul 4, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
Merge branch 'main' into modulelocals
4c59e51 
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
markshannon deleted the superblock-introspection branch August 6, 2024 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL