FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Partially annotate Argument Clinic CLanguage class by erlend-aasland · Pull Request #106437 · python/cpython · GitHub

/ cpython Public
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
25 changes: 19 additions & 6 deletions Tools/clinic/clinic.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,14 @@ def __init__(self, filename):
self.cpp = cpp.Monitor(filename)
self.cpp.fail = fail

def parse_line(self, line):
def parse_line(self, line: str) -> None:
self.cpp.writeline(line)

def render(self, clinic, signatures):
def render(
self,
clinic: Clinic | None,
signatures: Iterable[Function]
) -> str:
function = None
for o in signatures:
if isinstance(o, Function):
Expand All @@ -764,7 +768,10 @@ def render(self, clinic, signatures):
function = o
return self.render_function(clinic, function)

def docstring_for_c_string(self, f):
def docstring_for_c_string(
self,
f: Function
) -> str:
if re.search(r'[^\x00-\x7F]', f.docstring):
warn("Non-ascii character appear in docstring.")

Expand Down Expand Up @@ -1345,7 +1352,7 @@ def parser_body(prototype, *fields, declarations=''):
return d2

@staticmethod
def group_to_variable_name(group):
def group_to_variable_name(group: int) -> str:
adjective = "left_" if group < 0 else "right_"
return "group_" + adjective + str(abs(group))

Expand Down Expand Up @@ -1441,8 +1448,12 @@ def render_option_group_parsing(self, f, template_dict):
add("}")
template_dict['option_group_parsing'] = format_escape(output())

def render_function(self, clinic, f):
if not f:
def render_function(
self,
clinic: Clinic | None,
f: Function | None
) -> str:
if f is None or clinic is None:
return ""

add, output = text_accumulator()
Expand Down Expand Up @@ -1504,10 +1515,12 @@ def render_function(self, clinic, f):

template_dict = {}

assert isinstance(f.full_name, str)
full_name = f.full_name
template_dict['full_name'] = full_name

if new_or_init:
assert isinstance(f.cls, Class)
name = f.cls.name
else:
name = f.name
Expand Down

Back | FazBrowse Home | New Git URL