FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104584: Handle EXTENDED_ARG in superblock creation by gvanrossum · Pull Request #106489 · python/cpython · GitHub

/ cpython Public

gh-104584: Handle EXTENDED_ARG in superblock creation - #106489

Merged
gvanrossum merged 2 commits into
python:mainfrom
gvanrossum:uops-extended-arg
Jul 6, 2023
Merged

gh-104584: Handle EXTENDED_ARG in superblock creation#106489
gvanrossum merged 2 commits into
python:mainfrom
gvanrossum:uops-extended-arg

Conversation

gvanrossum commented Jul 6, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Also fixed and cleaned up test_capi.test_misc.TestUops, and added a new test proving that EXTENDED_ARG works.

gvanrossum commented Jul 6, 2023
edited
Loading

Copy link
Copy Markdown
Member Author

Tests are failing. I'll regroup and see if my EXTENDED_ARG handling is at fault or if it was pre-existing, and then proceed from there. For now, this is another Draft PR, and I'll isolate my test cleanups in a new PR.


UPDATE: Fixed by gh-106492, rebased, undrafted.

gvanrossum marked this pull request as draft July 6, 2023 20:42

gvanrossum commented Jul 6, 2023
edited
Loading

Copy link
Copy Markdown
Member Author

I get the same failure with just Fix and clean up uops and executor API. That makes me think the root problem is pre-existing (since that commit has no C code). I'll see if the address sanitizer will help me debug this.


UPDATE: Yeah, the UOpOptimizer type was missing a tp_dealloc handler. Nasty. Fixing that in gh-106492. Once that's merged I'll rebase and undraft this.

gvanrossum force-pushed the uops-extended-arg branch from ba006c1 to f11ebff Compare July 6, 2023 22:50
gvanrossum marked this pull request as ready for review July 6, 2023 22:51
gvanrossum merged commit e1d45b8 into python:main Jul 6, 2023
gvanrossum deleted the uops-extended-arg branch July 6, 2023 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL