gh-104584: Allow unspecialized instructions in superblocks - #106497
Merged
gvanrossum merged 5 commits intoJul 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This adds a whole bunch of unspecialized opcodes to superblocks. While we may not want that eventually, for now this helps finding bugs.
Copy link
Copy Markdown
Member
|
I'm hoping that our specialization will become good enough that it will be become largely irrelevant whether we include unspecialized instructions or not. If it helps testing, then let's add them. As you say, we can also remove them later if they are a problem. |
Sorry, something went wrong.
gvanrossum
enabled auto-merge (squash)
July 7, 2023 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done by not searching for forbidden words inside #if ENABLE_SPECIALIZATION. (And making that flag false when the Tier 2 uops are being compiled.)
@markshannon, I know this is controversial, but while we are incrementally developing superblock generation, I find it helpful if there are as many superblocks as possible, and those are as long as possible. Allowing unspecialized instructions helps towards this goal (and is quicker than inventing new specializations). I'm making it its own PR so hopefully it will be easy to roll back in the future. (In fact, all you'd have to do is change the one call to variable_used_unspecialized in generate_cases.py back to variable_used, and regenerate.)