FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-106052: Fix bug in the matching of possessive quantifiers by serhiy-storchaka · Pull Request #106515 · python/cpython · GitHub

/ cpython Public

gh-106052: Fix bug in the matching of possessive quantifiers - #106515

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:re-possesive-quant-nested-backtrace
Aug 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-106052: Fix bug in the matching of possessive quantifiers#106515
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:re-possesive-quant-nested-backtrace

Conversation

serhiy-storchaka commented Jul 7, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

It did not work in the case of a subpattern containing backtraces.

Temporary implement possessive quantifiers as equivalent greedy qualifiers in atomic groups.

serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 7, 2023
bedevere-bot mentioned this pull request Jul 7, 2023
Closed
serhiy-storchaka force-pushed the re-possesive-quant-nested-backtrace branch from d73d88e to 1a420c0 Compare July 7, 2023 12:46

ferdnyc commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

@serhiy-storchaka

Nit: (and not necessarily one that needs to be addressed directly) -- do you mean "backtracking", where you write "backtraces"?

pythongh-106052: Fix bug in the matching of possessive quantifiers
89bf9dc 
It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups.
serhiy-storchaka force-pushed the re-possesive-quant-nested-backtrace branch from 1a420c0 to 89bf9dc Compare July 10, 2023 08:09

serhiy-storchaka commented Jul 10, 2023

Copy link
Copy Markdown
Member Author

Thank you @ferdnyc. Fixed.

serhiy-storchaka commented Jul 10, 2023

Copy link
Copy Markdown
Member Author

It is a last resort. It will be merged if we not find a fix for POSSESSIVE_REPEAT implementation before the next releases.

Yhg1s commented Jul 10, 2023

Copy link
Copy Markdown
Member

Since 'the next releases' for Python 3.12 is today, do you want this in for 3.12.0 beta 4, or wait for rc1?

serhiy-storchaka commented Jul 10, 2023

Copy link
Copy Markdown
Member Author

I think it can wait for rc1, but we should not miss bugfix release for 3.11.

gpshead commented Jul 26, 2023

Copy link
Copy Markdown
Member

rc1 is in a few days if you want this in before then. I don't think this is really a release blocker even if it does sound nice to fix. 3.11 users already have to deal with the bug existence even if we manage to get a fix into a patch release.

serhiy-storchaka merged commit 7b6e34e into python:main Aug 9, 2023

miss-islington commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

serhiy-storchaka deleted the re-possesive-quant-nested-backtrace branch August 9, 2023 05:48

miss-islington commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7b6e34e5baeb4162815ffa4d943b09a58e3f6580 3.12

miss-islington commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7b6e34e5baeb4162815ffa4d943b09a58e3f6580 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 9, 2023
[3.11] pythongh-106052: Fix bug in the matching of possessive quantif…
d9686c0 
…iers (pythongh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Aug 9, 2023

Copy link
Copy Markdown

GH-107795 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 9, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 9, 2023
[3.12] pythongh-106052: Fix bug in the matching of possessive quantif…
bfcee6c 
…iers (pythongh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Aug 9, 2023

Copy link
Copy Markdown

GH-107796 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 9, 2023
serhiy-storchaka added a commit that referenced this pull request Aug 9, 2023
[3.11] gh-106052: Fix bug in the matching of possessive quantifiers (G…
5b76eaf 
…H-106515) (GH-107795)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups.
(cherry picked from commit 7b6e34e)
Yhg1s pushed a commit that referenced this pull request Aug 9, 2023
[3.12] gh-106052: Fix bug in the matching of possessive quantifiers (G…
3bb43b7 
…H-106515) (#107796)

[3.12] gh-106052: Fix bug in the matching of possessive quantifiers (gh-106515)

It did not work in the case of a subpattern containing backtracking.

Temporary implement possessive quantifiers as equivalent greedy qualifiers
in atomic groups..
(cherry picked from commit 7b6e34e)
serhiy-storchaka removed their assignment Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL